From 7021f6c734bd501c50c39be0721ca4889fd5ac95 Mon Sep 17 00:00:00 2001 From: Tom Li Date: Wed, 2 Jan 2019 11:37:48 +0800 Subject: [PATCH] sc.h: correct access violation in load_key_vector(), close #2. In load_key_vector(), the program passes a std::vector to a C-style function, load_key (const byte*begin, const byte*end) by creating references load_key (& (K[0]), & (K[K.size()])); However, accessing the one-past-the-last element in a std::vector via [] is not allowed in C++, it triggers an assertion failure. Assertion '__builtin_expect(__n < this->size(), true)' failed. In this commit, we use K.data() and K.data() + K.size() to expose the underlying pointers and pass them to the C function. Signed-off-by: Tom Li --- src/sc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sc.h b/src/sc.h index daf01b0..c2008fa 100644 --- a/src/sc.h +++ b/src/sc.h @@ -50,7 +50,7 @@ public: } void load_key_vector (const std::vector&K) { - load_key (& (K[0]), & (K[K.size()])); + load_key (K.data(), K.data() + K.size()); } typedef std::map*> suite_t;